aclap-dev / vdhcoapp

Companion application for Video DownloadHelper browser add-on
GNU General Public License v2.0
1.8k stars 290 forks source link

How to refresh detection? #225

Open rsalmei opened 5 months ago

rsalmei commented 5 months ago

After downloading something from a streaming website, the original content keeps playing, of course. And I can't download a new portion of it without first refreshing the page... The detected video is gone as soon as we press download, changed into a downloading handle, and when we click stop there are two cases:

In any case, I can't download it again. How to make the download handle reappear? Is it possible for it to automatically reappear in case the video is still streaming? If not, how about a Refresh button? By the way, a Refresh button would nicely complement the Clean and Clean All buttons, one undoing the other. Thanks!

paulrouget commented 5 months ago

How to make the download handle reappear?

On the left of the Play button, there's a retry button:

Screenshot 2024-05-24 at 09 40 19
rsalmei commented 5 months ago

Thanks, but unfortunately, it is not the same behavior. By clicking Retry, the entire frame won't hide again, they will simply stay there on the list even after changing the selected tab. And, after only two or three plus their downloaded ones, the list quickly starts to pile up and become unmanageable. I can barely find the newly detected ones on a new tab anymore.

rsalmei commented 5 months ago

When a download is finished, all it would take is to auto-refresh the list of detected videos.

Or, just allow us to show a Refresh button in it:

image

We can already optionally show Clean buttons, which I don't particularly appreciate as I prefer auto-hiding to keep it clean, but a Refresh button is surprisingly missing:

image
paulrouget commented 5 months ago

I'm not exactly sure to understand what you want.

You want a button to re-detect videos in that page? Refreshing the page itself doesn't do the tric?

rsalmei commented 5 months ago

Yes, it does, but it's a much more expensive action. It would be much faster if only the addon could do a refresh instead of the whole page, which also has to reconnect chat and video. I've been doing this, but I don't know why, after a few times it makes my Firefox stop connecting altogether.

paulrouget commented 5 months ago

Do you mind sharing from which website you're downloading?

On twitch, this seems to work as you want.

rsalmei commented 5 months ago

Hi @paulrouget.

Actually, not. I just tested on twitch, on a live stream, and it doesn't work.

For example, I downloaded a portion of a live stream here: https://www.twitch.tv/alanzoka It generated alanzoka - Twitch.mp4, and now the popup is empty:

image

So, to grab another portion, I have to refresh the whole page.

If I uncheck "Automatically hide downloaded media", it does show the previous video where I can click re-download, but with a BIG caveat:

image

If I change tabs now (I have to use several tabs at the same time), the above previous video SHOWS THERE TOO:

image

And it quickly becomes overwhelming and unmanageable:

image

And what if I click re-download now?? Yikes, it is even worse:

image
  1. the previously downloaded video doesn't go away,
  2. a new entry is added to download it again
  3. and these entries show in every single tab I select...

I hope that helps to understand the problem. I just wanted to keep tabs isolated, hiding content generated or available on other tabs, and being able to simply download a new portion of a stream without refreshing the page.

paulrouget commented 5 months ago

the previously downloaded video doesn't go away,

You can always click on the "x", no?

a new entry is added to download it again

Yes.

and these entries show in every single tab I select...

Yes, I know about this. It's actually necessary, but I think I can work around that issue.

I'll work on improving the Twitch integration. I understand it's not great at the moment.

rsalmei commented 5 months ago

I can click on x, sure, but there may be several downloads running at the same time, so it's not that easy to find it. And, I already click STOP, there shouldn't be another required click.

That's why "Automatically hide downloaded media" is the best option for me. This keeps tabs completely isolated from each other.

All that is needed for me is a simpler way to show the video again on the pop up, so I can download it again. It is streaming after all. If not automatically, at least a button for doing it manually. Anything that doesn't require reloading the whole website page. Thank you!

paulrouget commented 5 months ago

Ok, I get you! Thank you for the details and all.

I want to improve the unknown-length streaming situation.