search

aclap-dev / vdhcoapp

Companion application for Video DownloadHelper browser add-on
GNU General Public License v2.0
1.8k stars 290 forks source link

File name of downloaded videos #229

Open rsalmei opened 5 months ago

rsalmei commented 5 months ago

Hi, The downloaded videos are getting "beautified" names, which unfortunately ruin the original streamer name. For example: https://www.twitch.tv/cazetv_ => gets downloaded as CazeTV - Twitch.mp4 https://www.twitch.tv/mark_martinsbr => markmartinsbr - Twitch.mp4 https://www.twitch.tv/dota2_paragon_ru => dota2paragonru - Twitch.mp4

I'm not sure which transformations it does (the first got capitalized and stripped, the second and third only stripped), but would it be possible to save with the exact name of the streamer? I'd like the username to be correct, so I can find the video origin.

Thank you.

rsalmei commented 5 months ago

Looking at the pages titles, it is still unknown how you name the files:

image

Here, it looks like the first one got only stripped (not capitalized anymore), the second got stripped and lowercased, and the third is the same... I can't understand how the video names are being generated at all, but could they be saved as the original?

paulrouget commented 5 months ago

Which version of VDH are you using on on which browser?

paulrouget commented 5 months ago

Are you saying the underscores should be preserved and they are not?

Can you try with 9.0.2.12 beta on Firefox (https://www.downloadhelper.net/beta) and confirm you're seeing the same behavior?

rsalmei commented 5 months ago

Which version of VDH are you using on on which browser?

Always the latest stable, on Firefox.

rsalmei commented 5 months ago

Are you saying the underscores should be preserved and they are not?

Yes, exactly.

Can you try with 9.0.2.12 beta on Firefox (https://www.downloadhelper.net/beta) and confirm you're seeing the same behavior?

Sure! I'll try it tomorrow and let you know.

rsalmei commented 4 months ago

I've tried it, the version is 9.0.2.12a1, but there is no change. The page https://www.twitch.tv/cazetv_ still generated "CazeTV - Twitch.mp4".

rsalmei commented 4 months ago

@paulrouget Ohh, I've noticed something weird now on this a1 version: When grabbing several clips (by refreshing the page), the sequence numbers are prepended with a zero, and the case changes!

  1. "CazeTV - Twitch.mp4"
  2. "cazetv - Twitch-01.mp4"
  3. "CazeTV - Twitch-02.mp4"
  4. "cazetv - Twitch-03.mp4"

EDIT: It seems this -01 style has been adopted for about a month now, but I hadn't noticed it before (I prefer without that zero, but no problem).