aclap-dev / vdhcoapp

Companion application for Video DownloadHelper browser add-on
GNU General Public License v2.0
1.72k stars 280 forks source link

.part files left behind when a manifest is removed mid-stream #42

Closed rbtcollins closed 3 years ago

rbtcollins commented 5 years ago

This happens with some live broadcasts, and results in an unusable stream - it would be much nicer to properly close off the .part file when this happens.

jkemp814 commented 5 years ago

I agree. I wish there was a way to auto-save the file every 5-10 minutes. At least then the files could be stitched together instead of a total lost. We lost our entire broadcast due to a cut in the feed. Now we manually start and stop so the files can be saved, but there is a gap in the stream.

jkemp814 commented 5 years ago

I have found setting "Chunked manifests CoApp requests" to on, seems to help.

jkemp814 commented 5 years ago

Can the ffmpeg in vdhcapp use the mkv container? in conjunction with the 'copy' codec? When I use my own locally installed ffmpeg directly, using those options, it works perfect.

ffmpeg -i hhtps://your_stream_here.m3u8 -c:v copy -c:a copy -loglevel error /save_to_here/out-$(date +"%H-%M-%m-%d-%y").mkv

There is hardly any CPU usage this way. If the stream is cut the mkv container does a much better job handling the manifest

mi-g commented 3 years ago

.part cleanup is the extension responsibility not the coapp which only provides low level tools.