search

aclap-dev / vdhcoapp

Companion application for Video DownloadHelper browser add-on
GNU General Public License v2.0
1.72k stars 280 forks source link

Updated GitRepositories and Versions #73

Closed callmenemo491 closed 3 years ago

callmenemo491 commented 4 years ago

Updated many git repository links and updated the versions to the 'latest'

this will solve/ close #51 and also includes: the PR code of: #44

@mi-g , are you able to merge this pull request into the code. (note there are several issue tickets, i think you can close also...)

ghost commented 3 years ago

This still has issues:

(cd $SRCDIR; git clone https://foo; cd foo; git checkout "$FOO_VER")

If git clone fails, cd will fail too but "git checkout" will not fail and it will change the branch that the main git is on.

It should not use ; as the command separator. It should use && to avoid running commands if there is a failure in a previous command.

(cd $SRCDIR && git clone https://foo && cd foo && git checkout "$FOO_VER")
callmenemo491 commented 3 years ago

@mettacrawler , thanks for the info., you are correct - so i have taken the feedback and updated the PR.

ghost commented 3 years ago

Is the converter even a requirement? It appears to me that is just ffmpeg, ffprobe and ffplay and the shared libraries to run those.

When I look at https://aur.archlinux.org/packages/vdhcoapp/ it makes no attempt to download the converter source code. It just uses the Arch Linux ffmpeg package as-is and it runs just fine that way.

I think it's more important to pay attention to node js dubnium LTS going EOL on April 30, 2021. That and found 23 vulnerabilities (7 low, 6 moderate, 10 high) and also 21 packages are looking for funding