Closed mattjegan closed 7 years ago
Looks good for all non-2.6: https://travis-ci.org/hugovk/vanity/builds/154506446
If 2.6 is being ditched, please also remove it from .travis.yml: https://github.com/aclark4life/vanity/blob/master/.travis.yml#L6
And from setup.py: https://github.com/aclark4life/vanity/blob/master/setup.py#L10
Should be good now 😄
Python 2.6 is no longer supported so could be dropped, see https://github.com/aclark4life/vanity/issues/27#issuecomment-252412410.
@mattjegan Would you like to resolve conflicts in this PR?
Sure, @hugovk , if it's not urgent I should be able to patch it up tomorrow.
In summary, @aclark4life and @hugovk, this PR removes support for python 2.6 and 3.2 as discussed here and in #27. It also removes the dependancy on requests
in favour of urllib
Looks good!
I'm not too bothered either way, but if 3.2 is still working, should it be left in, and just 2.6 removed?
Cheers, if we leave this PR as is, that is with requests
removed, then I think we should be fine leaving 3.2 in. However, if we keep requests
3.2 fails, as seen in the Travis output for #32
Yeah I say get rid of 3.2
support, it's > 5 years old now I think.
@mattjegan Merged, thanks!
Managed to make the json parsing work without requiring the
requests
package. Keeps the project lightweight.Now requires py2.7+
As discussed in issue #27
argparse
andcollections.OrderDict
are incompatible with py2.6 unless we add dependancies for theargparse
andordereddict
packages.