aclark4life / vanity

Get package download statistics from PyPI
GNU General Public License v2.0
66 stars 14 forks source link

Partially fixes #27 by supporting python 2.7+, removes requests dependancy. #28

Closed mattjegan closed 7 years ago

mattjegan commented 8 years ago

Managed to make the json parsing work without requiring the requests package. Keeps the project lightweight.

Now requires py2.7+

As discussed in issue #27 argparse and collections.OrderDict are incompatible with py2.6 unless we add dependancies for the argparse and ordereddict packages.

hugovk commented 8 years ago

Looks good for all non-2.6: https://travis-ci.org/hugovk/vanity/builds/154506446

If 2.6 is being ditched, please also remove it from .travis.yml: https://github.com/aclark4life/vanity/blob/master/.travis.yml#L6

And from setup.py: https://github.com/aclark4life/vanity/blob/master/setup.py#L10

mattjegan commented 8 years ago

Should be good now 😄

hugovk commented 7 years ago

Python 2.6 is no longer supported so could be dropped, see https://github.com/aclark4life/vanity/issues/27#issuecomment-252412410.

@mattjegan Would you like to resolve conflicts in this PR?

mattjegan commented 7 years ago

Sure, @hugovk , if it's not urgent I should be able to patch it up tomorrow.

mattjegan commented 7 years ago

In summary, @aclark4life and @hugovk, this PR removes support for python 2.6 and 3.2 as discussed here and in #27. It also removes the dependancy on requests in favour of urllib

hugovk commented 7 years ago

Looks good!

I'm not too bothered either way, but if 3.2 is still working, should it be left in, and just 2.6 removed?

mattjegan commented 7 years ago

Cheers, if we leave this PR as is, that is with requests removed, then I think we should be fine leaving 3.2 in. However, if we keep requests 3.2 fails, as seen in the Travis output for #32

aclark4life commented 7 years ago

Yeah I say get rid of 3.2 support, it's > 5 years old now I think.

hugovk commented 7 years ago

@mattjegan Merged, thanks!