Enable Coveralls for this repo

aclark4life / vanity

Get package download statistics from PyPI

GNU General Public License v2.0

66 stars 14 forks source link

Enable Coveralls for this repo #36

Closed hugovk closed 7 years ago

hugovk commented 7 years ago

Now we're adding more tests, it'd be great to track coverage too. The existing test are ready to use it.

@aclark4life Please could you enable coveralls.io for this repo? https://coveralls.io/repos/new

mattjegan commented 7 years ago

@hugovk @aclark4life And to stay on top of style perhaps landscape.io?

An example from one of my repos: https://landscape.io/github/mattjegan/rancat/31

hugovk commented 7 years ago

I've added Landscape: https://landscape.io/github/aclark4life/vanity

killvung commented 7 years ago

How about just using the coverage package from Python? I heard it's pretty solid...

Sometimes Keep It Simple Stupid is better than making it really complex at the beginning

hugovk commented 7 years ago

@killVung The coverage package is already being used to generate the coverage. Coveralls is just an place to keep track of the coverage over builds, and easier to check than having to dig into Travis CI logs: https://travis-ci.org/aclark4life/vanity/jobs/166537108#L1336

Here's how it looks for my fork: https://coveralls.io/github/hugovk/vanity

hugovk commented 7 years ago

Oh, looks like I do have permission to enable Coveralls for this repo, so here we go!

https://coveralls.io/github/aclark4life/vanity

killvung commented 7 years ago

I see sorry about lacking of observation

hugovk commented 7 years ago

Should another option be set for Landscape to check PRs?

mattjegan commented 7 years ago

@hugovk Perhaps fail if errors are found? If the score decreases I wouldn't be too worried since landscape is very pedantic

hugovk commented 7 years ago

Thanks, let's see how this goes: