aclark4life / vanity

Get package download statistics from PyPI
GNU General Public License v2.0
66 stars 14 forks source link

Add function docstrings #39

Closed hugovk closed 8 years ago

hugovk commented 8 years ago

Some of the functions in vanity.py have empty docstrings, for example:

def normalize(name):
    """
    """
    http = HTTPSConnection(PYPI_HOST)
    http.request('HEAD', '/pypi/%s/' % name)
    r = http.getresponse()
    if r.status not in (200, 301):
        raise ValueError(r.reason)
    return r.getheader('location', name).split('/')[-1]

It would be great to fill these in.

More info on docstrings:

masterp4dev commented 8 years ago

Hi @hugovk, I am jumping on this. Thanks

darthbhyrava commented 8 years ago

Hello @masterp4dev,

Sorry for the PR, I'd already started working on this. Please feel free to submit your own PR, it is entirely possible your changes might be more suited to @hugovk 's needs. :)

masterp4dev commented 8 years ago

It's fine @darthbhyrava 🙌