Implement test cases - Githubissues

aclark4life / vanity

Get package download statistics from PyPI

GNU General Public License v2.0

66 stars 14 forks source link

Closed killvung closed 7 years ago

killvung commented 7 years ago

Sorry about the white spaces problem, I am using Sublime without any plugins, so I don't realized the existence of them.

Also I had fixed some of the problems @hugovk mentioned

killvung commented 7 years ago

Should I also rename the class name to test_Normalize for consistency?
@hugovk Let me know

hugovk commented 7 years ago

@killVung Yes please.

killvung commented 7 years ago

I actually changed it while asking for it Have a look

hugovk commented 7 years ago

And please lowercase it for consistency too. Thank you!

killvung commented 7 years ago

Done

hugovk commented 7 years ago

I squashed this into a single commit and merged.

Thanks!

killvung commented 7 years ago

Thank you so much I appreciate it