search

aclark4life / vanity

Get package download statistics from PyPI
GNU General Public License v2.0
66 stars 14 forks source link

Python 3 compat and locale fix. #6

Closed JNRowe closed 12 years ago

JNRowe commented 12 years ago

Quick change to make vanity usable with Python 3 It remains compatible with Python 2.6+, and 2.5 didn't work before anyway.

The second change just ignores failures when attempting to set the locale to en_US, many installations won't have it available and users will face a traceback.

I will split these if you only want one or the other, and it makes your life easier.

Thanks,

James

While I have your attention it might be nice if the dependency on requests wasn't forced until it was actually used. It is probably making your life easier in some way, but it is a pretty hefty chunk of code to depend on when it isn't actually used.

aclark4life commented 12 years ago

Thanks!

aclark4life commented 12 years ago

I removed requests, I don't know why it was there. I probably thought I was going to use it and then never did.

aclark4life commented 12 years ago

Release 1.2.3. is on PyPI, thanks again.

JNRowe commented 12 years ago

Speedy, thanks!

aclark4life commented 12 years ago

Thanks to GitHub and http://pythonpackages.com :-)