search

aclements / libelfin

C++11 ELF/DWARF parser
MIT License
317 stars 99 forks source link

Add cmake support #31

Closed banshee closed 3 years ago

banshee commented 6 years ago

I added cmake support for myself (I wanted to use CLion), and I'm happy to add it in to the project if it's interesting for other people. There's some cleanup work to be done here before merge (although it's working), I just wanted to see if it's worth doing.

albertschulz commented 4 years ago

Would love to see CMake support for this repository. @aclements could this request be accepted?

banshee commented 4 years ago

Just FYI, it's been a long time since I touched anything to do with CMake, so I'm unlikely to be able to do contribute anything additional here. I had totally forgotten about this until I saw the update from a week ago.

banshee commented 4 years ago

Looks like there's another PR that includes cmake - https://github.com/aclements/libelfin/pull/37

Smertig commented 4 years ago

I wish this PR (or #37) would be accepted. CMake is the most popular tool for managing C++ build process.

@aclements, it would be great, if you take a look at this PR.

madebr commented 3 years ago

In addition to my remarks, cmake should also be tested on .travis.yml.

@banshee Do you intend to update your pr?

banshee commented 3 years ago

No, it's been two years since I touched this and I haven't written anything in CMake for, hmm, can't actually remember. I'm totally happy to do anything to help (that doesn't involve relearning CMake...), but my suggestion would be to take the file you ended up with and make it a new PR. Abandoning this PR would be totally fine with me.

banshee commented 3 years ago

My next suggestion - if you want to put together a better PR that other people could also pull in, I'll happily close this one in favor of yours. Things like "err, bash isn't exactly portable" are 100% true, and I think my original CMake files were pretty much the fastest thing I could get working. Given that it's been here for two years, I suspect it's never going to make it into the main line, but it'd probably be good to only have one outstanding PR that people can grab.

madebr commented 3 years ago

@banshee Thanks for the reply! I would love to propose a cmake pr myself, but I will not invest any time in this until @aclements (or someone who has commit access) comments on this.

banshee commented 3 years ago

Closing this so it won't show up in my PR list any more.