Added support for segments

aclements / libelfin

C++11 ELF/DWARF parser

MIT License

317 stars 99 forks source link

Added support for segments #6

Closed abenkhadra closed 8 years ago

abenkhadra commented 9 years ago

I've added support for reading program header segments. An example dump-segments.cc has been included to demonstrate the basic functionality.

Additionally, I've fixed a little bug in parsing ELF32 headers in function canon_hdr. I encountered the bug while reading ARM executables.

aclements commented 8 years ago

Thanks for the PR! The code looks good; my comments are all about maintaining consistency and comment cleanups. Could you also update the commit messages to follow the standard git convention of using present tense? E.g., "Fix canon_hdr to read ELF32 correctly", "Add support for reading ELF segments", etc.

abenkhadra commented 8 years ago

I've revised PR based on your comments.