aclist / kbin-kes

Add-on manager and scripting framework for kbin
MIT License
24 stars 8 forks source link

[BUG] Unintended interaction between Resize Text mod and Collapsible Comments mod #273

Open aclist opened 5 months ago

aclist commented 5 months ago

If the Resize Text mod is on, toggling the Collapsible Comments mod on/off triggers a timeout and opacity check on the KES modal, because this behavior of the Resize Text mod resides in the global scope and the Collapsible Comments change triggers recursion throughout the page

aclist commented 5 months ago

Provisionally resolved by 02440f3, but Collapsible Comments causes the entire DOM for #comments to mutate, triggering all mods to iterate and apply. Resize Text now explicitly checks if the KES modal is on the Resize Text mod before applying opacity, but some observations about this side effect:

aclist commented 5 months ago

The opacity issue is resolved by 02440f3, but I still feel there is room for improvement here so that the collapsible comments mod itself does not trigger a mutation that forces recursion through all mods. However, this may be intractable in the current design.