Open fulldecent opened 1 day ago
All green now ✅
EDIT: It seems there's now URL related issues MD034/no-bare-urls Bare URL used
. Looking into a fix for that
@fulldecent your recent merge may have broke the links:
It's caused by the prettier spacing issue which was why I added the <!-- prettier-ignore -->
Is it possible to workaround instead of using ignore?
Not sure yet. Would look into it. Is there a reason using the ignore is an issue (in the short term at least)?
Basically when we use an ignore it typically results in some problem later
Another solution is adding bracketSameLine: true
to the .prettierrc.js
file and running the command yarn run prettier-fix
command.
Please update all our email links to "awesome mailto links" to pass the build. Use a _include/mailto.html to wrap the process of generating these links, which might not be obvious.
There's a couple of tricks to make the correct include file, which needs to:
Mail us at {% include ... body=... ... %}.
Specifically there is a conflict between Prettier which likes to add a blank line at end of files, but kramdown (in Jekyll) which breaks if a Markdown includes extra line breaks.
Here is basically how to circle that square: