acls-training-center / rnmobility.com

Learn how to use your RN license in another state.
https://rnmobility.com
0 stars 1 forks source link

Awesome mailto #69

Open fulldecent opened 1 day ago

fulldecent commented 1 day ago

Please update all our email links to "awesome mailto links" to pass the build. Use a _include/mailto.html to wrap the process of generating these links, which might not be obvious.

There's a couple of tricks to make the correct include file, which needs to:

Specifically there is a conflict between Prettier which likes to add a blank line at end of files, but kramdown (in Jekyll) which breaks if a Markdown includes extra line breaks.

Here is basically how to circle that square:

{%- comment
body
subj
to
linkText
... explain inputs
{%- endcomment -%}
<a href=....... and MAKE sure to escape stuff properly</a>
{%- comment -%}
This comment is here just to eat (see the `-`) the following whitespace which would mess up surrounding Markdown source.
See: https://github.com/jekyll/jekyll/issues/9691
{%- endcomment -%}
[ PRETTIER PUTS A NEWLINE HERE ] 
codiini commented 9 hours ago

All green now ✅

EDIT: It seems there's now URL related issues MD034/no-bare-urls Bare URL used. Looking into a fix for that

codiini commented 7 hours ago

@fulldecent your recent merge may have broke the links:

image

It's caused by the prettier spacing issue which was why I added the <!-- prettier-ignore -->

fulldecent commented 7 hours ago

Is it possible to workaround instead of using ignore?

codiini commented 7 hours ago

Not sure yet. Would look into it. Is there a reason using the ignore is an issue (in the short term at least)?

fulldecent commented 6 hours ago

Basically when we use an ignore it typically results in some problem later

codiini commented 6 hours ago

Another solution is adding bracketSameLine: true to the .prettierrc.js file and running the command yarn run prettier-fix command.