Closed alexwgraves closed 2 years ago
Changes from feedback:
Code style/DRYness changes:
mobile.css
getPercentOffset
toMoney
toLocaleString
useK
false
updateViewBox
ScatterPlot
dx
dy
data["key"]
data.key
Changes from feedback:
Code style/DRYness changes:
mobile.css
getPercentOffset
to helpers since we use the logic in lots of placestoMoney
that lets us usetoLocaleString
(setuseK
tofalse
)updateViewBox
forScatterPlot
to just updatedx
anddy
values on the svg elements rather than deleting and re-rendering them every timedata["key"]
accesses todata.key
; I think these were my fault lol, can you tell I usually only write python?