Closed alexwgraves closed 4 years ago
I don't know enough CSS to give that portion a meaningful review. But I read it and it looks good to me.
Everything else looks fine - feel free to merge if you don't want to deal with the tick that's slightly-off on my screen (it might look fine on your screen, which brings up the scary possibility that it could look different on different screens)
The tick is fixed on my end! This is good to merge whenever you'd like
Changes
table.css
. You should be able to install the regular one (i.e. not condensed) and have the rest of the text work fine — this seems to be an issue with how the font file is constructed for thefont-stretch
property.BarGraphCell
andNumberLineCell
for the visualizations. The former should only ever take one number, whereas the second can display up to two.NumberLineCell
over a bunch of the graphs, andBarGraphCell
can probably be extended for the bail type distribution tablestype
of the visualization when you pass in the data array:bar
forBarGraphCell
andline
forNumberLineCell
.VizHeaderCell
which extendedHeaderCell
and displays the ticks and numbers for the start and end of the graphs as well as for the average(s)Table.js
. I had to adjust the padding manually until the ticks lined up with the average line in the cells. I'm going to keep looking into this, but for the time being those hand-coded values are relative to the width of the text box, which isn't ideal.mobile.css
. It's not perfect, but everything fits without horizontal scrolling on a modern-sized phone. (Think iPhone X, Pixel, but not like an iPhone SE or one of the smaller ones. They can deal with some scroll.)