search

aclu-cash-bail-team / aclu-cash-bail

Code powering ACLU Pennsylvania's Broken Rules interactive
https://www.brokenrulespa.org
2 stars 0 forks source link

Viewall #8

Closed apothuku closed 3 years ago

apothuku commented 4 years ago

Changes

This PR builds on the inclusion of all county data and multi-search. Initially, users only see the first 10 rows of the table. They can click View All to see all rows, and then Collapse to return to 10 rows.

A few questions on behavior:

  1. Row truncation applies to search as well - when there are more than 10 search results, users will have to click View All to see all results. Would we prefer to show all search results regardless?
  2. When there are less than 10 search results, the View All button doesn't appear to the user to have any effect when clicked. Should we disable the button when there are less that 10 search results?
apothuku commented 4 years ago

Addressed comments