search

aclu-national / elections-api

An API for retrieving locally-relevant structured data about US elections
https://elections.api.aclu.org/v2/
MIT License
30 stars 4 forks source link

update bioguide and wikipedia scripts #47

Closed alisonag closed 4 years ago

alisonag commented 4 years ago

A new http://bioguide.congress.gov/ is coming soon, and the path we've been using to pull our images no longer work. This fixes the path for now, but we will likely need to update this again once the new site launches.

I also realized we were missing the pup dependency for the wikipedia script in Docker. I was having some trouble installing this in docker though, and since we don't use it anywhere else, it seemed easier to rewrite how we scrape wikipedia for the image. I removed the dependency on pup and use the wikipedia API to grab the image url from the JSON instead. Not sure if there's a reason we were scraping the page rather than using the API?

kokonakajima commented 4 years ago

omg sorry i tried to approve this and hit the wrong button