search

aclu-people-power / map

ACLU People Power Map
MIT License
3 stars 12 forks source link

Sticky header #101

Open Chrissy opened 7 years ago

Chrissy commented 7 years ago

It's a sticky header!

stickysticky

Chrissy commented 7 years ago

ok @stuartsan this is about ready to go. Let me know what you think!

stuartsan commented 7 years ago

Overall this looks really nice and I dig the animation! I had just a couple comments, one bug and one idea for an improvement.

Chrissy commented 7 years ago

@stuartsan ok round 2 for your leisurely perusal. One controversial line in header.js, which I left a comment on.

stuartsan commented 7 years ago

Ah, sorry @Chrissy ! I forgot to take a look at this, will look soon.

stuartsan commented 7 years ago

@Chrissy , sorry for my delayed response here. I added a couple thoughts, overall it looks great. There are some conflicts in Header.html that I'm not sure how to resolve correctly -- if you wouldn't mind resolving those, let's merge this thang!

Chrissy commented 7 years ago

@stuartsan nice! I will fix the conflicts and address the comment this evening.

Chrissy commented 7 years ago

ok everything is conflict-free and I made that one change! @stuartsan