aclu-people-power / map

ACLU People Power Map
MIT License
3 stars 12 forks source link

Mobile and desktop external links #102

Closed tasandberg closed 7 years ago

tasandberg commented 7 years ago

Responsive styling for the buttons according to #91 and #92. Also style adjustments happen when map is active vs inactive (list). TODO:

stuartsan commented 7 years ago

This is looking good!! The big thing IMO is to check after bringing up to date with master that layout stuff generally still look good across chrome/FF/ie11.

tasandberg commented 7 years ago

I addressed all of your notes, I think. Event list is back in place, everything seems to look good after merge with master and some adjustments.

Getting the event list in mobile mode to take up its whole height and push the footer below was proving really hard, hence the display: block in mobile mode.

Biggest problem is that the sharing link strategy looks like its not going to work as far as sharing the specific map URL. For now its 'functional', it goes to the share page with just the hostname. I think we might need to script up something more elaborate and possible register the app with FB in order to make a share dialog with our own images/logos/etc, as well as the proper url with map params.

stuartsan commented 7 years ago

I left a couple new comments on little bugfixes, otherwise this is looking awesome, thanks @Timmehs !

stuartsan commented 7 years ago

:ship: it