search

aclu-people-power / map

ACLU People Power Map
MIT License
3 stars 12 forks source link

Add margin, height to toolbar dropdown buttons #106

Closed fouad closed 7 years ago

fouad commented 7 years ago

Which issue or problem is this solving?

Request for comments

Tested on multiple screen sizes, there didn't seem to be any issues

@cbcowans

stuartsan commented 7 years ago

Thanks for the contribution @fouad ! This is closely related to #104 so I want to hold on merging this and see if we can address them both at once.

In general in this project we are trying to avoid hardcoded fixed pixel dimensions for things -- I feel like we might be able to do something similar to what you've done here but set the height of all these buttons at once, based on rems or something. Will take a closer look at this later this afternoon.

fouad commented 7 years ago

Cool sgtm! @stuartsan will close for now & we can re-open, consider merging (or changing to rems)