Specify MSRV for `profiling` and `profiling-procmacros` and verify in CI

aclysma / profiling

Provides a very thin abstraction over instrumented profiling crates like puffin, optick, tracy, and superluminal-perf.

Apache License 2.0

324 stars 41 forks source link

Specify MSRV for `profiling` and `profiling-procmacros` and verify in CI #72

Closed FreezyLemon closed 7 months ago

FreezyLemon commented 7 months ago

Supersedes #69. (See that PR for discussion)

The cache entries for check-msrv are relatively big (~450MiB). This seems to be intended. Any rust version >= 1.70 will use a different registry checkout mode (sparse), so newer versions don't have this issue.

If cache size is a concern, I could look into fixing this manually.

FreezyLemon commented 7 months ago

Note that the first run took a while (~3 mins) due to missing cache entries. I have a run on my fork that has a populated cache which shows a runtime of <20 seconds. So it shouldn't impact CI speed at all under normal circumstances because the clean job takes longer to complete.

aclysma commented 7 months ago

Thanks again, much appreciated!