search

acm-uiuc / beats

Beats by ACM
11 stars 19 forks source link

Inline Track Info Editing #7

Open calvin-shirley opened 10 years ago

calvin-shirley commented 10 years ago

There should be a way for users to edit the database information of songs (to correct song titles, etc.). Information should only be editable by admins and maybe the uploader of the song.

colegleason commented 10 years ago

Does editing the DB propagate to the ID3 tags of the file?

On Tue, Mar 4, 2014 at 3:29 PM, CJS7070 notifications@github.com wrote:

There should be a way for users to edit the database information of songs (to correct song titles, etc.). Information should only be editable by admins and maybe the uploader of the song.

Reply to this email directly or view it on GitHubhttps://github.com/acm-uiuc/acoustics2/issues/7 .

Cole Gleason Student, University of Illinois at Urbana-Champaign Computer Science, Class of 2015 cg@colegleason.com | colegleason.com

zachreizner commented 10 years ago

I think it should not. Editing music is beyond the scope of this. Changing just the database is sufficient for searches and display on the frontends.

calvin-shirley commented 10 years ago

AFAIK it doesn't at the moment, but my biggest concern is searching and display. There are lots of songs in Acoustics right now that don't have titles, and as such you can't find them unless you search for the filename itself or the uploader (not ideal).

kevinwang commented 10 years ago

The way song adding is currently implemented, any corrections would be overwritten the next time the song adding routine executes.

zachreizner commented 10 years ago

Maybe instead of removing the songs in the directory before readding them as your routine currently has it, store a file hash in the song model and don't add any song files whose hash is already in the database. This would keep any metadata in the database from being replaced.

nhandler commented 10 years ago

If you do something like that, make sure the database has a way to clean itself up. For example, if a user has a song that gets added to the DB and then they modify it locally (or delete it), we don't want to wind up with stale DB entries.

kevinwang commented 10 years ago

Issue number conflicts from merging two repos.