search

acm-uiuc / groot-api-gateway

API Gateway for the Groot project written in Arbor
Other
12 stars 2 forks source link

Docker Service Changes #63

Closed bcongdon closed 7 years ago

bcongdon commented 7 years ago

So, here are the changes to the services that need to be made for the api-gateway to work in the docker container network.

Can you think of a better way to configure this? It's going to make having a dev environment not hosted in docker difficult... Maybe have the hostname for each service live in one of the config.go?

narendasan commented 7 years ago

I wonder what the most ideal development flow would be, if docker is easier that non docker I think its ok. but I dont typically do dev in docker myself so I am not sure

narendasan commented 7 years ago

A config file may work, however we should then include in the template both versions and you could comment or uncomment what you want to use

narendasan commented 7 years ago

Also can you base this branch off of the arbor branch? I want to merge that first

narendasan commented 7 years ago

make sure to update any references to groot to groot-api-gateway (the executable should be renamed in the arbor PR)

bcongdon commented 7 years ago

kk, I think I hit all the necessary references

narendasan commented 7 years ago

should this be pointed at master now?

bcongdon commented 7 years ago

Yup