search

acm-uiuc / groot-desktop-frontend

Desktop Frontend for Groot
Other
7 stars 12 forks source link

Integrate OAuth and fetch R|P resumes #164

Closed sameetandpotatoes closed 6 years ago

sameetandpotatoes commented 6 years ago

This integrates into the R|P api with OAuth and allows users to view R|P resumes. It's a little difficult right now to actually do filtering, as I'll need to integrate much further into the R|P api and move away from Groot. Also it doesn't seem like R|P's schema has netids defined which makes things tricky to "fallback" on ACM resumes.

Note: All of this was tested locally, without using the actual Google OAuth app set up. I created a fake OAuth app, ran the R|P api locally, and tested the flow like that.

To get this to actually work, we'll need to add: http://acm.illinois.edu/rp/auth to the list of authorized redirect URIs. Despite that, there may be some other issues that need to be ironed out.

therishidesai commented 6 years ago

@ASankaran ^

narendasan commented 6 years ago

Does it make sense to integrate this into the ACM infrastructure this way? Having two backends for the frontend especially when one is just for a specific use case doesn't make a ton of sense to me. It seems like we are adding a very heavy dependency on the frontend alone, especially because now there are multiple authentication schemes flying around (past the two already supported)

I think there are three major options that seem reasonable in my mind:

  1. R|P's api becomes a listed as a service in the groot api gateway and everything re: R|P hits the "RP service" which is just RP's gateway and we take it from there
  2. We stand up an events/RP specific frontend for the resume book targeting the RP gateway as a consumer (imo this is the cleaner solution - it can just be a fork of desktop frontend with all the extra stuff thrown out)
  3. We do what liquid did and just use the ACM Corporate Resume Book out right with an ACM Resume Book account instead of an RP oauth account
ASankaran commented 6 years ago

I think @narendasan's second solution is the best. The RP / HackIllinois API was not designed to interface directly with ACM infrastructure.

I think we should have a separate front end for the resume book (and use dns to run it on resumebook.reflectionsprojections.org) or integrate it into the RP site (at reflectionsprojections.org/resumebook). Separate would be preferable to that we can run the same frontend (with a different theme) for HackIllinois.

sameetandpotatoes commented 6 years ago

Discussed with @ASankaran and @apache8080 - we'll table this. The UI for rp and hackillinois doesn't really need to happen at this point - DB queries can suffice for that, until we have the resources to make a separate front end completely separate from Groot (and not tied to net ids, etc)