search

acm-uiuc / liquid

ACM@UIUC's website code (Django)
acm.uiuc.edu
15 stars 33 forks source link

Refactor out grid resizing JS #327

Closed ace-n closed 9 years ago

ace-n commented 9 years ago

As title

ace-n commented 9 years ago

Assigning @achalv to sign off - @colegleason you're welcome to do this too. Just want to make sure I'm not doing anything silly.

colegleason commented 9 years ago

Can I get a screenshot here?

ace-n commented 9 years ago
screen shot 2015-08-01 at 6 05 36 pm

(N.B: Since my copy of the DB is out of date, I disabled JS on the live-site page and added my CSS changes to get this image.)

colegleason commented 9 years ago

What happens when we get enough sponsors to span multiple lines?

What was the JS solving that is now not needed?

ace-n commented 9 years ago

Sponsors on multiple lines:

screen shot 2015-08-08 at 5 02 02 pm

Masonry is (according to its site) a library for doing grid layouts on pages with rectangles of different, dynamic sizes. Since all the logos should be the same size (and are pretty close to it right now), we don't need to have such a library in use.

colegleason commented 9 years ago

Ok, LGTM then.

On Sat, Aug 8, 2015, 2:05 PM Ace Nassri notifications@github.com wrote:

Sponsors on multiple lines: [image: screen shot 2015-08-08 at 5 02 02 pm] https://cloud.githubusercontent.com/assets/2309317/9152261/4f2e4fb0-3def-11e5-809a-1c74b0a5bdf9.png

Masonry is (according to its site) a library for doing grid layouts on pages with rectangles of different, dynamic sizes. Since all the logos should be the same size (and are pretty close to it right now), we don't need to have such a library in use.

— Reply to this email directly or view it on GitHub https://github.com/acm-uiuc/liquid/pull/327#issuecomment-129044722.