search

acm-uiuc / liquid

ACM@UIUC's website code (Django)
acm.uiuc.edu
15 stars 33 forks source link

Remove admin names from contact page since they change so frequently … #346

Closed calvin-shirley closed 8 years ago

calvin-shirley commented 8 years ago

…and are always outdated. And to remove my name since I'm still getting communications directly because of this page.

ace-n commented 8 years ago

LGTM, except for that first
on line 29. (Sorry if I wasn't clear in my line note.)

@sskhandek This might be pedantic, but the other entries have names as well. Should we list a name or two here (for stylistic consistency && in case we need to contact a specific person on Admin), or are we OK with Admin not having a specific contact name unlike the others?

calvin-shirley commented 8 years ago

I removed the extra
but at least one of them needs to be there.

Admin is under a lot of fluctuation now and we will be discussing this in the coming semester. Right now, there are effectively no specific contact points. For the time being, it's best to leave it blank. The contact e-mail is what's important.

ace-n commented 8 years ago

Whoops, looks like you're right about the
thing - if @sskhandek (or any other member of Top4) signs off on this change, then I'll merge it.

tl;dr: Looks good, just need someone on Top4 to approve not having a name listed.

sskhandek commented 8 years ago

I approve. Thanks for running this by me.