search

acm19 / aws-request-signing-apache-interceptor

https://acm19.github.io/aws-request-signing-apache-interceptor/
Apache License 2.0
16 stars 6 forks source link

Add support for SimpleHttpRequest #102

Open SnuK87 opened 1 year ago

SnuK87 commented 1 year ago

Issue #, if available: #101

Description of changes:

Pull Request Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dblock commented 1 year ago

Doing https://github.com/dblock/aws-request-signing-apache-interceptor/commit/63473c88d364ab1212cdcc653c993b96949b7623 seems to fix this, or at least the unit test passes. Does it work @SnuK87? If yes I think that's the best we can do. Want to take that code and finish this PR?

acm19 commented 1 year ago

@dblock this won't work as the actual call to the interceptor uses a BasicHttpRequest rather than a SimpleHttpRequest, my thoughts: https://github.com/acm19/aws-request-signing-apache-interceptor/issues/101#issuecomment-1556150389