search

acm19 / aws-request-signing-apache-interceptor

https://acm19.github.io/aws-request-signing-apache-interceptor/
Apache License 2.0
17 stars 6 forks source link

Make request interceptors simpler and other improvements #104

Closed acm19 closed 1 year ago

acm19 commented 1 year ago

Reduces code in the interceptor by setting back the body at the same time it's retrieve. Since the body is not modified during the signing process it's not necessary to have the same conditions twice in the code.

Removes check for final parameters as it mostly makes the code more verbose and it helps very little in such a small library.

Removes use of deprecated httpClient.execute methods replacing it by the currently supported versions of the same method, updates the documentation accordingly.

Bumps the version of the testing OpenSearch cluster to 2.5.

Pull Request Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

acm19 commented 1 year ago

@dblock if you have a cluster running, please double check the examples work before merging:

make run_all_samples