search

acm19 / aws-request-signing-apache-interceptor

https://acm19.github.io/aws-request-signing-apache-interceptor/
Apache License 2.0
16 stars 6 forks source link

`Aws4Signer` has been marked as deprecated #121

Closed reibitto closed 1 week ago

reibitto commented 3 months ago

I was trying to upgrade the aws sdk to version 2.25.69 and now I see a deprecation warning for Aws4Signer: https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/auth/signer/Aws4Signer.html

In the docs it suggests using software.amazon.awssdk.http.auth.aws.signer.AwsV4HttpSigner. I didn't investigate too much beyond checking to see if AwsV4HttpSigner was a drop-in replacement for Aws4Signer, but from what I can tell it's not. I'm not sure how involved the actual solution to this or what the path forward is, but I thought I'd create an issue here to track it or start a discussion for some ideas.

dblock commented 3 months ago

Thanks for opening this @reibitto. Try upgrading this repo using AwsV4HttpSigner and see what happens?

dblock commented 3 weeks ago

@reibitto There's a PR ready in https://github.com/acm19/aws-request-signing-apache-interceptor/pull/125, test it out?

reibitto commented 3 weeks ago

Oh sorry I forgot to get back to this issue. I haven't deployed our real app with this but I installed the 3.0.0-SNAPSHOT dependency locally and ran a manual test with it and it seems to work fine to me.

Thanks!