search

acm19 / aws-request-signing-apache-interceptor

https://acm19.github.io/aws-request-signing-apache-interceptor/
Apache License 2.0
16 stars 6 forks source link

Enforce GitHub issues in checkstyle configuration #96

Closed dblock closed 1 year ago

dblock commented 1 year ago

Trying to change checkstyle.xml TodoComment doesn't seem to have any effect when running mvn validate -Pcheckstyle.

Also note that mvn checkstyle:check doesn't use that configuration.

acm19 commented 1 year ago

Trying to change checkstyle.xml TodoComment

What's not working exactly, this works for me. By default checkstyle TodoComment matches only TODO case sensitive.

Also note that mvn checkstyle:check doesn't use that configuration.

This is by design, but the GitHub job uses validate with the proper profile, so it properly validate checkstyle. For speed locally you can use make checkstyle.