search

acmacalister / skittles

Simple terminal colors in golang
MIT License
11 stars 1 forks source link

Don't format text with %s, use %v #1

Closed langston-barrett closed 8 years ago

langston-barrett commented 8 years ago

In the signature of Skittles' methods, text is an interface{}. However, in the format strings, skittles uses %s instead of the more general %v. I'm happy to put a PR in, would you accept one?

acmacalister commented 8 years ago

I would. That would be good change. I originally had it as %s format specific sense text use to be a string. Then I wanted to print other types (such as errors) and never went back and changed it to %v.