Open sakrifor opened 5 years ago
First of all: Do you know how Course Exemptions actually work for our uni? Has the student taken the course/examination, and why are they listed separately?
Fixes: We properly detect them now in HTML & PDF parsers in commits ecfc7d25bc98630aa64608e138427741909b43d3 and 6df340e3a89f49e86bf72cdcbb328da25bcb4c23 respectively.
Missing grades: We still have to decide what to do with those that don't have a grade. For now, the csv with the results will just have a blank grade, like so:
NCO-01-05, ΒΑΣΙΚΕΣ ΑΡΧΕΣ ΠΡΟΓΡΑΜΜΑΤΙΣΜΟΥ, Υ, 2018 - 2019, ΦΕΒΡ, 9, 7, 9,
P.S. How come some of them have a grade and some do not?
@din0s I have no idea, let's consider this resolved for now.
There are cases where there are Απαλλαγές Μαθημάτων where some have grades and some do not. This case must be resolved in both PDFParser and HTML Parser. In the latter case the issue has been resolved with a hot fix https://github.com/acmauth/GradeParser/commit/5452a7cbfcc34fde2bbaafa33d61a9dd75271b78 which should be refactored. Cases where the grade of these courses is not specified should be assigned with 5. This matter is open to discussion.