acmerobotics / ftc-dashboard

React-based web dashboard designed for FTC
https://acmerobotics.github.io/ftc-dashboard
Other
168 stars 125 forks source link

Refactor - Co-locate dependent components #114

Closed NoahBres closed 1 year ago

NoahBres commented 1 year ago

No functional changes. Just moving things around before another PR. Separating the PR's to make the next one easier to navigate.

Prior:

After:

NoahBres commented 1 year ago

I see more tailwind lints in this diff. Is there a way to lint all the files and keep subsequent diffs a little cleaner?

I did not even think to solve this problem. They support a prettier plugin now!

I'd prefer absolute imports everywhere. I figure this is just a lint setting? Is there a problem with this approach?

Just to clarify, you'd like to enforce using import foo from '@/bar' everywhere? If so, do you have a preference for the alias? I chose @/ -> ./src as I've seen it used elsewhere but I am totally open to using something like ~/ or whatever would make more sense.

rbrott commented 1 year ago

Thanks for making the changes! @/ is perfect.