Closed BD103 closed 8 months ago
@rbrott this is now ready as a minimum viable product. I do have a few additional questions, though:
short
, byte
, and / or char
?
@rbrott this is now ready as a minimum viable product.
Great work, thanks for the patch.
* Should I add support for `short`, `byte`, and / or `char`? * I feel they're less common, so I don't know if it's worth implementing it (yet).
I agree, those can wait.
* Do you want me to remove the [test configuration](https://github.com/acmerobotics/ftc-dashboard/pull/150/files#diff-f2ed284d340b830a45aacf109e4d4895ebbc84710b1868472bf3724f6618e382) or is it fine to keep?
Fine to leave it.
* Should the web client check that the number is less than 263? It seems to silently error out when a too large number is given.
I don't think we need to address proper bounds right now. It would be nice to add full support for longs in the future, but this is a useful improvement as-is.
@rbrott would you mind publishing a new release with this pull request? My team needs the feature, but I'm unsure of how to depend on a Git repository.
This is a draft PR that adds support for more Java primitive types. Closes #148.
Todo
long
float
Optional
short
byte
char