acmerobotics / ftc-dashboard

React-based web dashboard designed for FTC
https://acmerobotics.github.io/ftc-dashboard
Other
171 stars 130 forks source link

Disable Dashboard should be accessible from DS #43

Closed dgorbunov closed 3 years ago

dgorbunov commented 3 years ago

With the onset of Control Hubs, it is important to be able to disable the dashboard from the Driver Station phone.

TimVargo commented 3 years ago

I was going to make a very similar comment. Problem is that the DS code is not open source like the RC code is, so how could this be accomplished? Perhaps a disable command could be built into the RC web interface, and/or an API call?

rbrott commented 3 years ago

I see two easy options:

I think I prefer the latter.

I guess disabling from the UI is convenient, but the enable/disable asymmetry bothers me.

dgorbunov commented 3 years ago

Thanks for adding this. This could just be me, but upon bumping the version to 0.40 in build.gradle and syncing, it seems FtcDashboard.java isn't updated to include the new op mode registering. Is there something I'm doing wrong? I've tried invaliding gradle cache and deleting all of it.

rbrott commented 3 years ago

I intend for registration to happen automatically without any changes. To suppress it, pass true to FtcDashboard.start().

dgorbunov commented 3 years ago

That method is not present in FtcDashboard for me, just start().

dgorbunov commented 3 years ago

For some reason 0.3.10 is only visible to FtcRobotControllerActivity but in other classes I can access version 0.4.0

rbrott commented 3 years ago

Ah you will have to update the version in both Gradle files.

dgorbunov commented 3 years ago

Ah, totally missed that. Thanks!

TimVargo commented 3 years ago

Nicely done!