acmerobotics / ftc-dashboard

React-based web dashboard designed for FTC
https://acmerobotics.github.io/ftc-dashboard
Other
171 stars 129 forks source link

documentation for teams migrating from 0.4.2 #70

Closed IronReignRobotics closed 2 years ago

IronReignRobotics commented 2 years ago

If you used dashboard 0.4.2 or earlier, there were numerous places you had to sprinkle integration code into ftcrobotcontroller.java.

That seems to have been done away with by using annotation hooks, but it took a bit of work to figure that out and remove those bits. Please add some documentation to help previous users migrate.

But we haven't been fully successful. When we go to the dash page we are getting the response:

Mime type unknown: uri='/dash' path='dash'

In case it matters, this is for an OpenRC project

rbrott commented 2 years ago

In case it matters, this is for an OpenRC project

Check that your OpenRC distribution includes the RC web server.

NoahAndrews commented 2 years ago

All OpenRC variations should include the webserver, beginning with OpenRC 5.5B.

IronReignRobotics commented 2 years ago

It does include the web server. I can see the onbot java environment in a browser when I downgraded dashboard back to 0.4.2, though pulling up dashboard crashes because of 7.0 sdk version changes.

On Fri, Oct 15, 2021 at 5:37 PM Noah Andrews @.***> wrote:

All OpenRC versions since 5.5B should include the webserver.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/acmerobotics/ftc-dashboard/issues/70#issuecomment-944786625, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRFRSIWYBK33XKQY555V5TUHCUKXANCNFSM5F6IKF4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rbrott commented 2 years ago

Oh right, the web server is obviously running to display that message. I still suspect some OpenRC-specific issue though... I'll see if I can investigate in the next few days.

IronReignRobotics commented 2 years ago

Further documentation refinement since OpenRCTurbo doesn't include a build.dependencies.gradle file:

In build.gradle at the project root add to the end of allprojects { repositories { maven { url = 'https://maven.brott.dev/' }

add to the end of dependencies in build.gradle for both FTCRobotController and TeamCode: implementation('com.acmerobotics.dashboard:dashboard:0.4.3') { exclude group: 'org.firstinspires.ftc' }

IronReignRobotics commented 2 years ago

If you can provide any advice on how to debug the hooks mechanism, that would be helpful. But don't put further effort into that. I went ahead and downloaded pristine copies of the official ftcrobotcontroller v7 as well as the current OpenRCTurbo and configured the current ftc-dashboard on both. It worked in both cases. So there must be something we need to correct in our codebase's migration for all the updates.

rbrott commented 2 years ago

I would make sure your merged FtcRobotControllerActivity includes all of the hook calls (e.g., this menu one). If you haven't otherwise modified FtcRobotControllerActivity, I would copy over the latest version.

IronReignRobotics commented 2 years ago

Thanks for the help, there were merge errors in update to 7.0. It's working now.