Bump deps

[NoahBres]

Significant package changes:

• Bump node version in gradle build
  • FtcDashboard/build.gradle
  • 12.13.0 -> 18.12.1
  • 18.12.1 is the latest LTS version
    • Went through the changelog for versions 12 -> 18. There are no breaking changes.
  • Node version 16+ is required for the build to work on m1 macbooks
• vite: 2 -> 3
  • https://vitejs.dev/blog/announcing-vite3.html
  • Cold start improvements
  • Architecture changes for SSR. Irrelevant
  • @vitejs/plugin-react-refresh uninstalled, replaced by @vitejs/plugin-react
  • tsconfig compiler option targeting ESNext
    • ES5 option deprecated
  • react-scripts package removed. Relic from create-react-app
• react: 17 -> 18
  • https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html
  • Summary:
    • No relevant changes. Primarily underlying architecture changes for React Server Compontents which is irrelevant to Dash
    • Automatic Batching: neat but no noticeable changes
• redux: 4.0 -> 4.2
  • https://github.com/reduxjs/redux/releases
  • createStore deprecated with recommendation to move to @reduxjs/toolkit. Details in changelog. No changes to Dash required but deprecation will halt further upgrades
• react-redux: 7 -> 8
  • https://github.com/reduxjs/react-redux/releases
  • React 18 compatibility
  • Internal TypeScript codebase rewrite
• redux-thunk: 2.3 -> 2.4
  • Internal TypeScript codebase rewrite
• tailwindcss: 2 -> 3
  • https://tailwindcss.com/blog/tailwindcss-v3
  • JIT by default. Removal of @tailwindcss/jit package
  • Colored box shadows. No need for custom extension in tailwind.config.js. Removed.
  • Variants on by default thanks to jit
  • Colors enabled by default thanks to jit

Misc

• Pre-commit hooks removed
  • Although ideal to ensure consistency, this introduces unnecessary friction during development
    • Instead, instructions for ESLint and Prettier autoformatting will be included and encouraged. Checks should be done prior merge rather than per-commit.
    • I am sure literally zero people used these anyways as git commit hooks need to be explicitly installed upon clone
• Add npm run dev, equivalent to current npm run start
  • npm run dev seems to have overtaken npm run start as the standard in terms of default ecosystem documentation assumptions. Just a small convenience change
• Tailwind CSS:
  • Every color in the palette is included by default now. Thus, colors are no longer overriden
    • yellow -> amber
  • Colored shadows were implemented. Custom shadows were removed
  • A number of classes were moved around by an updated auto-formatter
• Fixing bug where state is entirely cleared rather than appended to in OpModeView (introduced in #72)
• Type changes to Redux Thunk. Ignored in socketMiddleware.ts
• React 18 createRoot
  • https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis

[NoahBres]

Verified on running opmode ✅

[rbrott]

"Bump deps" definitely undersold this. Thanks for some much-needed maintenance!

Pre-commit hooks removed

I use them 😄 Can you elaborate on the development friction? Does it just encourage fewer, bigger commits? I'd generally rather handle formatting this way than set up GH actions or something.

Fixing bug where state is entirely cleared rather than appended to in OpModeView (introduced in Address getGamepads changes #72)

I didn't even catch it on my second review. Silly setState() semantics.

[NoahBres]

I use them 😄 Can you elaborate on the development friction? Does it just encourage fewer, bigger commits? I'd generally rather handle formatting this way than set up GH actions or something.

This is entirely irrelevant but regarding previous work in a professional setting, they just proved to be an annoyance as the hooks are generally very slow and you were discouraged from making frequent commits. Commits failing for linting errors felt incredibly unnecessary since you were not really concerned until merging into the main branch. I've had similar discussions with other teams. However, this is completely irrelevant to dash's development given that so few people work on it—and so infrequently. Also, my laptop is fast enough where I don't notice how slow hooks used to be—unsure if that carries for average users. I just wasn't aware that anyone used it since they are not automatically installed and recent PR's have not complied. I was working off of a new device and had forgotten that the pre-commit hooks existed. I think if you find this useful, I will definitely re-include them. I am going to add some documentation eventually so it is encouraged to set them up.