Thanks for the patch! I'm not totally opposed, though I have some concerns:
I like keeping Encoder simple and restricted to only the operations needed by RR tools. I have no ambition to make Encoder a de facto SDK interface that exposes the full capabilities of the hardware.
Setting the motor mode to DcMotor.RunMode.STOP_AND_RESET_ENCODER and back affects the underlying motor. This is easy to fix by storing an offset provided teams don't care about overflow (and I imagine very few do).
Thanks for the patch! I'm not totally opposed, though I have some concerns:
Encoder
simple and restricted to only the operations needed by RR tools. I have no ambition to makeEncoder
a de facto SDK interface that exposes the full capabilities of the hardware.DcMotor.RunMode.STOP_AND_RESET_ENCODER
and back affects the underlying motor. This is easy to fix by storing an offset provided teams don't care about overflow (and I imagine very few do).