acmesh-official / acme.sh

A pure Unix shell script implementing ACME client protocol
https://acme.sh
GNU General Public License v3.0
38.8k stars 4.92k forks source link

nsupdate env variables should be saved per-certificate (not saved in account.conf) #2092

Open muks opened 5 years ago

muks commented 5 years ago

Thank you for acme.sh. It is very suitable for me.

I request that acme.sh not save NSUPDATE_* variables into account.conf, but instead put them into the specific certificate-name.conf, because names may belong in different zones (different values for NSUPDATE_ZONE, NSUPDATE_KEY and NSUPDATE_SERVER).

I've worked around the issue by using different --home for different name domains. However it feels unusual and it would be better to move the settings to the certificate conf.

If this can already be done in some other way, please let me know.

Thank you.

doits commented 4 years ago

:+1: otherwise you can only update one (the last) zone/nameserver

doits commented 4 years ago

I found out that you can manually add the variable to the domain's *.conf for the time being. So at least you can manually work around the issue after issuing the first certificate. Automatic renews will work then.

bjoe2k4 commented 4 years ago

I'd be in favor to at least store it by default in the domains *.conf as well.