search

acmesh-official / acme.sh

A pure Unix shell script implementing ACME client protocol
https://acme.sh
GNU General Public License v3.0
37.87k stars 4.86k forks source link

Report bugs to Vultr dns api #2374

Open Fudoshiki opened 5 years ago

Fudoshiki commented 5 years ago

This is the place to report bugs in the Vultr DNS API.

If you experience a bug, please report it in this issue.

Thanks!

mjkrg commented 3 years ago

Failure to remove DNS record

In function dns_vultr_rm, on line 81, grep "$txtvalue" should be grep -- "$txtvalue" to allow removal of TXT records beginning with a hyphen (-).

Neilpang commented 3 years ago

@mjkrg fixed. please upgrade to dev

acme.sh  --upgrade -b dev
skyksandr commented 2 years ago

I hit rate limit when trying to issue a single certificate for 3 domains. I found out vultr api v1 has rate limit of 2 requests/sec and vultr api v2 - 30, so I made a PR: https://github.com/acmesh-official/acme.sh/pull/4192 to use v2 instead of v1

mjkrg commented 1 year ago

On line 119, containing the command grep '^\{.*\}', on FreeBSD it needs an -E option to be able to parse the extended regular expression otherwise it chokes with the error message: "grep: repetition-operator operand invalid". I don't know about other systems so tests on those systems may be required.

----- Original Message ----- Date: Mon, Jul 18, 2022 at 1:38 AM From: Aleksandr Kunin @.> To: "acmesh-official/acme.sh" @.> Cc: mjkrg @.>, Mention @.> Subject: Re: [acmesh-official/acme.sh] Report bugs to Vultr dns api (#2374)

I hit rate limit when trying to issue a single certificate for 3 domains. I found out vultr api v1 has rate limit of 2 requests/sec and vultr api v2 - 30, so I made a PR: https://github.com/acmesh-official/acme.sh/pull/4192 to use v2 instead of v1

-- Reply to this email directly or view it on GitHub: https://github.com/acmesh-official/acme.sh/issues/2374#issuecomment-1186676624 You are receiving this because you were mentioned.

Message ID: @.***>

skyksandr commented 1 year ago

@mjkrg does -E mean the same on FreeBSD as on macOS:

 -E, --extended-regexp
             Interpret pattern as an extended regular expression (i.e., force grep to behave as egrep).
mjkrg commented 1 year ago

Yes, that's exactly how the man page describes it.

----- Original Message ----- Date: Fri, Aug 19, 2022 at 6:00 AM From: Aleksandr Kunin @.> To: "acmesh-official/acme.sh" @.> Cc: mjkrg @.>, Mention @.> Subject: Re: [acmesh-official/acme.sh] Report bugs to Vultr dns api (#2374)

@mjkrg does -E mean the same on FreeBSD:

 -E, --extended-regexp
             Interpret pattern as an extended regular expression (i.e., force grep to behave as egrep).

-- Reply to this email directly or view it on GitHub: https://github.com/acmesh-official/acme.sh/issues/2374#issuecomment-1220283883 You are receiving this because you were mentioned.

Message ID: @.***>

skyksandr commented 1 year ago

@mjkrg sorry it took thaaat long. Today @Neilpang merged #4266 that addresses this issue.