acmesh-official / acme.sh

A pure Unix shell script implementing ACME client protocol
https://acme.sh
GNU General Public License v3.0
39.39k stars 4.97k forks source link

Feature request: support notifications using msmtp in mail.sh #2582

Open marcoc610 opened 5 years ago

marcoc610 commented 5 years ago

I prefer using msmtp as mailer in place of the unmantained ssmtp. Please apologize if I only post a diff between my modified script and the original one. Here is how I modified notify/mail.sh script. Comments/corrections are welcome.

$ diff mail.sh mail.sh.orig
83,84d82
<   elif _exists "msmtp"; then
<     _MAIL_BIN="msmtp"
92c90
<     _err "Please install sendmail, msmtp, ssmtp, mutt or mail first."
---
>     _err "Please install sendmail, ssmtp, mutt or mail first."
108c106
<     msmtp | ssmtp)
---
>     ssmtp)
123c121
<     sendmail | ssmtp | msmtp )
---
>     sendmail | ssmtp)

Maybe someone wants to include this in a pull request?

Neilpang commented 4 years ago

please send PR

brackenhill-mob commented 4 years ago

+1

There is now a PR - please can this be accepted and a new version released urgently as ssmtp is no longer maintained and does not work on Debian Buster

TIA