acmesh-official / acme.sh

A pure Unix shell script implementing ACME client protocol
https://acme.sh
GNU General Public License v3.0
38.39k stars 4.89k forks source link

Request to migrate to grep -E #4928

Open PolarianDev opened 8 months ago

PolarianDev commented 8 months ago

Hello,

I seem to remember it being mentioned that no migration to grep -E will be made because it would break backwards compatibility, however I can't seem to find this thread now. In case I was wrong, I am making this issue.

Could you migrate to grep -E as GNU's grep implementation will drop egrep as its deprecated in the following versions, and acme.sh is likely to no longer work on such systems.

Linked issue: #4835 Linked commit with comments: fe890c62f4229c8696d85edfd2336130214135db Potential solution: https://github.com/acmesh-official/acme.sh/commit/fe890c62f4229c8696d85edfd2336130214135db#commitcomment-134504860

Thank you, Polarian

github-actions[bot] commented 8 months ago

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

yurtpage commented 3 months ago

GNU grep implementation will drop egrep

That will never happen ;-)

The warning is printed to stderr and it's safe to just eat it so that was made in the fe890c6. Wait for the next release.