acmpesuecc / Consoles_India_StockNotifier

0 stars 3 forks source link

Refactor Configuration files to External Config File #2

Open shri30yans opened 2 weeks ago

shri30yans commented 2 weeks ago

Currently, the main config, product and website configurations are hardcoded, making it difficult to manage and update. We should refactor this into a separate configuration file to improve maintainability, reduce clutter in the code, and allow for easier updates in the future.

Proposed Solution:

Steps to Implement:

  1. Create a new configuration file (e.g., products_config.yaml and website_config.yaml).
  2. Move all product/website data into this configuration file.
  3. Modify the existing Python file to parse and load the configuration at runtime.
  4. Test to ensure that functionality remains the same and all products are correctly loaded from the configuration file.

Additional Considerations:

Benefits:

Spinicle commented 2 weeks ago

Please assign this issue to me!

shri30yans commented 2 weeks ago

!assign @Spinicle

bunsamosa-bot[bot] commented 2 weeks ago

Hey @shri30yans! The timer for the @Spinicle to work on the issue has finished, deassign and assign a new contributor or extend the current timer. Contact maintainer leads if inactive @DedLad @polarhive @achyuthcodes30

Spinicle commented 2 weeks ago

I need an extension, had gone for dinner for about 25 minutes.

shri30yans commented 2 weeks ago

!assign @Spinicle

bunsamosa-bot[bot] commented 2 weeks ago

Hey @shri30yans! The timer for the @Spinicle to work on the issue has finished, deassign and assign a new contributor or extend the current timer. Contact maintainer leads if inactive @DedLad @polarhive @achyuthcodes30

Spinicle commented 2 weeks ago

Can I get reassigned? Still working on this, it's a tad bit long

shri30yans commented 2 weeks ago

!deassign @Spinicle

shri30yans commented 2 weeks ago

!assign @Spinicle

Spinicle commented 2 weeks ago

I'm a little sick and it wasn't helping whatsoever with this complex thing.

bunsamosa-bot[bot] commented 2 weeks ago

Hey @shri30yans! The timer for the @Spinicle to work on the issue has finished, deassign and assign a new contributor or extend the current timer. Contact maintainer leads if inactive @DedLad @polarhive @achyuthcodes30

shri30yans commented 2 weeks ago

@Spinicle Let me know if you need help. Which room are you in? Let's complete it.

Spinicle commented 2 weeks ago

Hey! Yeah so as much as I'd love to work on this, it's a little too much for me at the moment so I thought about doing another issue, but the bot isn't assigning me. Could you de-assign? I will get back to this later if it isn't already taken up someone

shri30yans commented 2 weeks ago

!deassign

shri30yans commented 2 weeks ago

Seems like you are already deassigned. Let me know if there is a issue.

Spinicle commented 2 weeks ago

Seems like you are already deassigned. Let me know if there is a issue.

I'm not able to be assigned to another issue. Been trying for a while now

shri30yans commented 2 weeks ago

!assign @Spinicle

shri30yans commented 2 weeks ago

!deassign @Spinicle

MeghanaK11 commented 2 weeks ago

Can I get assigned to this issue

shri30yans commented 2 weeks ago

!assign @MeghanaK11

bunsamosa-bot[bot] commented 2 weeks ago

Hey @shri30yans! The timer for the @MeghanaK11 to work on the issue has finished, deassign and assign a new contributor or extend the current timer. Contact maintainer leads if inactive @DedLad @polarhive @achyuthcodes30