acmpesuecc / boomcaster

A simple doom-esque game built with pygame and a custom coded raycaster
0 stars 16 forks source link

cache optimised update 1 #8

Open lithium-anode opened 6 days ago

bunsamosa-bot[bot] commented 6 days ago

Thank you from Opening this Pull Request, @lithium-anode ! A Maintainer will review it soon!

lithium-anode commented 6 days ago

I noticed a parameter error in my code and so i pushed a new commit "cache optimised update 2"

lithium-anode commented 6 days ago

@Icarus131 can you please review the most recent commit i pushed

Icarus131 commented 6 days ago

check the performance diff again, looks like it is a negative change

lithium-anode commented 6 days ago

check the performance diff again, looks like it is a negative change

alright, i'll look into it

lithium-anode commented 6 days ago

i have pushed the new commit with the corrected code. the optimised code performs faster

lithium-anode commented 6 days ago

@Icarus131 please review this code and let me know if there are any changes i should make

lithium-anode commented 6 days ago

Screenshot 2024-10-19 at 7 00 02 AM

lithium-anode commented 6 days ago

Screenshot 2024-10-19 at 7 00 34 AM

lithium-anode commented 6 days ago

@Icarus131 , I pushed a new commit which uses cache from functools. Im also attaching the output screenshots. i ran the code 10 times and i got a decrease in time in majority of these cases. can you please review this-

output_screenshots.pdf