acmpesuecc / recipe-manager

Simple recipe manager written in Java
MIT License
0 stars 11 forks source link

Closes #3 Try to add label support #9

Closed Delta18-Git closed 3 days ago

Delta18-Git commented 3 days ago

This may work.

bunsamosa-bot[bot] commented 3 days ago

Thank you from Opening this Pull Request, @Delta18-Git ! A Maintainer will review it soon!

Samyukta-b commented 3 days ago

yes i will look into this

Delta18-Git commented 3 days ago

Sorry, I realised I hadn't committed all the changes. 🙏🏻

Delta18-Git commented 3 days ago

@Samyukta-b Please do tell me if this isn't how this works, so I can close this PR and try attempting other repos. 🙏🏻

(Sorry for the amount of @ s)

Samyukta-b commented 3 days ago

hi, yes im sorrry it took a long to review this, i'm looking at it right now

Samyukta-b commented 3 days ago

there is an error with the RecipeMOdel where you have defined the List labels. a list cannot sit in a a table, try using a join table anotation

Delta18-Git commented 3 days ago

This is slightly confusing to me given that ingredients is a list here, and it sits fine?

Delta18-Git commented 3 days ago

Does it work now @Samyukta-b ? Sorry, quite a dumb mistake.

Delta18-Git commented 3 days ago

Did a bit more research, would the JoinTable be used to map recipe ids to labels? If so, committing now.

Delta18-Git commented 3 days ago

It seems to me, if it is needed to implement JoinTable, it would need to be changed from a String list to a custom type List...

Delta18-Git commented 3 days ago

I think this is where the code should work, please get back if it is still broken. @Samyukta-b 🙏🏻

Samyukta-b commented 3 days ago

hi im working on it at the moment!

Samyukta-b commented 3 days ago

!bounty 300

bunsamosa-bot[bot] commented 3 days ago

Assigned 300 Bounty points to user @Delta18-Git !

Samyukta-b commented 3 days ago

i need you to do one thing actually

Samyukta-b commented 3 days ago

can you please add @ElementCollection just above the List labels

Samyukta-b commented 3 days ago

and update the PR again

Delta18-Git commented 3 days ago

That's what I did though, image

Samyukta-b commented 3 days ago

hmm okay than, thanks

Delta18-Git commented 3 days ago

🙏🏻

DedLad commented 1 day ago

!bounty 80

bunsamosa-bot[bot] commented 1 day ago

Assigned 80 Bounty points to user @Delta18-Git !