search

acmpesuecc / weatherforecast

Weather Forecast is a simple GUI weather information search engine built using Python. Users can search for the weather based on cities.
MIT License
1 stars 17 forks source link

Display the units along with the values on the GUI #8

Closed charan2308 closed 1 year ago

charan2308 commented 1 year ago

At the moment, only the numerical values of temperature, and pressure are being displayed. Make changes such that the units are mentioned along with the numerical values.

bunsamosa-bot[bot] commented 1 year ago

Thank you for opening this issue! A Maintainer will review it soon!

nik2203 commented 1 year ago

hi can i be assigned to this PES2UG21CS334 Nikhil Girish

charan2308 commented 1 year ago

@nik2203 go for it , revert back within 15 mins

vrac10 commented 1 year ago

hi , can i be assigned to this PES2202200278 Rachit verma

nik2203 commented 1 year ago

@nik2203 go for it , revert back within 15 mins

im almost done, gonna submit pr in a min

charan2308 commented 1 year ago

@vrac10 I have already assigned this issue to someone who had requested earlier. Hence not able to assign the issue to you :(

charan2308 commented 1 year ago

@nik2203 cool, waiting for it

nik2203 commented 1 year ago

@nik2203 cool, waiting for it

submitted 👍🏽 thank you so much for waiting

charan2308 commented 1 year ago

@nik2203 good job, but also make sure that the units are displayed on the GUI also. Hint: concatenate the unit to the value while changing the text of the label in the fetch() function. Giving you 10-15 mins for this.

nik2203 commented 1 year ago

@nik2203 good job, but also make sure that the units are displayed on the GUI also. Hint: concatenate the unit to the value while changing the text of the label in the fetch() function. Giving you 10-15 mins for this.

got it. im currently unable to create an account on the website mentioned in the readme though. what should i do?

nik2203 commented 1 year ago

@nik2203 good job, but also make sure that the units are displayed on the GUI also. Hint: concatenate the unit to the value while changing the text of the label in the fetch() function. Giving you 10-15 mins for this.

updated 👍🏽. units now appear on gui and concatenation fixed

charan2308 commented 1 year ago

@nik2203 good job, have assigned 5 bounty points and 5 brownie points for extra effort :)