acmucsd / main-website

Official Website of ACM UC San Diego
https://acmucsd.com/
4 stars 6 forks source link

Updated Event Page Layout #276

Closed farisashai closed 1 year ago

farisashai commented 1 year ago

Description

Changelog

  1. Proposed Redesign for ACM Event page to essentially use the mobile layout at all times with a max width so event images never get cropped.

    Before

    Screenshot 2023-04-12 at 1 59 41 PM

After

Screenshot 2023-04-12 at 1 59 02 PM

  1. Also fixed a minor error for a recent PR on event cards.

  2. Fixed a layout bug with overflowing text title by switching title container from grid to flex on mobile.

    Before

    Screenshot 2023-04-12 at 3 17 04 PM

After

Screenshot 2023-04-12 at 3 17 34 PM

  1. Added a hover effect on Add to Calendar Screenshot 2023-04-12 at 3 15 25 PM

  2. Removed all references to Facebook links (All ACM event links now link to event page)

  3. Type of change

How Has This Been Tested?

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
main-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 10:15pm
farisashai commented 1 year ago

The changes look good! I just have one comment: the "Add to Calendar" buttons look a little weird spacing-wise, is there a better way to style them here instead of always having 2 on top and 1 on bottom? Screen Shot 2023-04-12 at 2 06 02 PM

Do you think it would look better with all 3 in a single column on mobile?

alexzhang1618 commented 1 year ago

I think if we have space, we should have all three in a row. Maybe using flex instead of grid to style the calendar link container would work better?

nishantbalaji commented 1 year ago

Looks great! However, we don't use facebook anymore so you can remove that button image