Changed create and edit event facebook field to indicate not optional (#579)

[trevorkw7]

Removed "(optional)" form the Facebook event link title to reflect that the Facebook event link is required to pass form validation.

Before

After

[trevorkw7]

This fixes the confusion on the UI right now but can we confirm the actual constraints we're placing on the user.

Does the portal API actually require this field or do we have unnecessary client-side validation right now?

The portal API doesn't require this field in the POST request but client-side validation is still happening because most admins creating events agree that creating a Facebook event for each event in the membership portal is a good practice.

[farisashai]

The portal API doesn't require this field in the POST request but client-side validation is still happening because most admins creating events agree that creating a Facebook event for each event in the membership portal is a good practice.

I kinda feel like this should be a standard enforced by our marketing team when they're filling out new events in that case rather than a mandatory front-end field if it's not actually required. I can imagine that not every single ACM event requires an event link so I'd rather allow this flexibility for them than potentially burden them more and make someone enter a fake nonsense URL to complete the submission.

[trevorkw7]

Makes sense to me. I'll update this pull request with a new commit to the frontend form validation to remove the requirement for a URL to be present in the field.