acmucsd / membership-portal

REST API for the UC San Diego ACM chapter's membership portal.
https://members.acmucsd.com
Mozilla Public License 2.0
17 stars 5 forks source link

Add names to retroactive attendance form #407

Closed ryanDing26 closed 6 months ago

ryanDing26 commented 8 months ago

Info

Closes #322.

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant motivation or context.

Faris wanted to change the functionality on the retroactive attendance form (within the admin dashboard) so that it displayed names in the format firstName lastName (email) so that it would be easier to autocomplete manual attendance by name instead of asking people for their email for points.

Changes

Type of Change

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

Checklist

Screenshots

Please include a screenshot of your Postman testing passing successfully.

image
github-actions[bot] commented 8 months ago

Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate.

dowhep commented 8 months ago

Nit: Since you will be returning an array of strings that concatenate names and emails, it would be cleaner and more correct to define a new type for such strings. Maybe make the field name "namesAndEmails" or something.

ryanDing26 commented 7 months ago

This is the final version I would like to submit for the PR. Let me know if any more changes need to be made!