acmucsd / membership-portal

REST API for the UC San Diego ACM chapter's membership portal.
https://members.acmucsd.com
Mozilla Public License 2.0
17 stars 5 forks source link

Feature/event route refactor #431

Open yimmyj opened 7 months ago

yimmyj commented 7 months ago

Info

Closes 429.

Description

implemented new routes:

feedback/event/:uuid: retrieves the user's feedback on a given event

event/:uuid/feedback: retrieves all feedback for a given event. [admin only]

removed current structure in feedbackcontroller that expects query params from frontend

Type of Change

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

Checklist

Screenshots

Get all feedback for event:

Screenshot 2024-04-08 at 12 32 56 AM

Get all feedback for event as a standard user (error):

Screenshot 2024-04-08 at 12 48 39 AM

Get own feedback for event:

Screenshot 2024-04-08 at 12 48 13 AM
github-actions[bot] commented 7 months ago

Thanks for contributing! If you've made changes to the API's functionality, please make sure to bump the package version—see this guide to semantic versioning for details—and document those changes as appropriate.

nik-dange commented 6 months ago

Marking as revisit for now. Waiting on design team to provide some updated designs for Feedback so we can restructure and rescope it on the backend